Add allow host access to Graaljs under flags - Githubissues

mobile-dev-inc / maestro

Painless Mobile UI Automation

https://maestro.mobile.dev/

Apache License 2.0

5.71k stars 260 forks source link

Add allow host access to Graaljs under flags #2022

Open tokou opened 3 weeks ago

tokou commented 3 weeks ago

Context

https://github.com/mobile-dev-inc/maestro/pull/1996#issuecomment-2324679424

Proposed changes

I also added MAESTRO_CLI_DANGEROUS_GRAALJS_ALLOW_ALL_ACCESS for allowAllAccess()
I added a disabled integration test for the case where the env var needs to be set as I don't think it's possible to mock System.env.
(Unrelated) Fix to .idea/.gitignore

Testing

Unit tests for truthness of env values
Integration tests

Issues fixed

Linked https://github.com/mobile-dev-inc/maestro/pull/1949 Linked https://github.com/mobile-dev-inc/maestro/pull/1996 Fixes https://github.com/mobile-dev-inc/maestro/issues/1388

bartekpacia commented 3 weeks ago

Tests failing because of false positive #2005

amanjeetsingh150 commented 1 week ago

Thanks for this PR @tokou 🙌 planning to merge this soon after the 1.39.0 release for 1.40.0. Adding a label for it.

amanjeetsingh150 commented 1 week ago

Just to confirm @tokou does this now enable importing different js modules? Mentioned in following issue:

https://github.com/mobile-dev-inc/maestro/issues/1637

tokou commented 1 week ago

Oh I haven't noticed that issue @amanjeetsingh150 I'll give it a look and see if this fixes it and if not will add another env var for it.