Open TheKohan opened 1 month ago
Hey @TheKohan -- About the tests, you can add a E2E test in the "e2e" module. About this feature, great delivery!
Is there a reason to limit it to id than reuse the existing complex element selector logic that exists for other commands?
Is there a reason to limit it to id than reuse the existing complex element selector logic that exists for other commands?
To be completely honest i didn't think about it, but i think you're right. Let me try to reimplement this part.
@Fishbowler - adjusted API acording to your suggestions, it's indeed way better this way. Thanks for the hint !
Added test cases.
@amanjeetsingh150 - can you review this PR ?
Hey @TheKohan this LGTM, we will be trying to get this in 1.40.0 CLI version.
Can you also raise a PR to update docs here:
Thanks for answering, i'll try to find some time next week to cover things you've mentioned !
Proposed changes
This PR extends current capabilities of
takeScreenshot
command withcropOn
prop which is of anElementSelector
type.Motivation
Visual regression testing is something that has been on the horizon for some time #1222. This PR is aiming to fill the gaps and prepare the ground for further development in this area (will fit #2078 great). Component level screenshots are something that will greatly decrease screenshot size and make component-level tests possible.
Example usage
test-screenshot.yml
test-component-screenshot.yml
Testing