mobile-dev-inc / maestro

Painless Mobile UI Automation
https://maestro.mobile.dev/
Apache License 2.0
5.88k stars 281 forks source link

fix: use noop insights by default on maestro #2131

Closed amanjeetsingh150 closed 1 week ago

amanjeetsingh150 commented 1 week ago

Proposed changes

Insights is a CLI-only concept. We've seen this implementation causing problems on the cloud. This PR provides a noop implementation to Insights by default so that we don't use it on cloud.

For CLI the real implementation is passed so that behavior of CLI remains unchanged

Testing

Locally running a command that raises insight. Tapping on optional view that's not there.

Issues fixed

linear[bot] commented 1 week ago

MA-2534 Stop using Insights class on maestro-client module