eminence
commented
2 years ago One of the problems with the 1.4.0 release is that we let github automatically create the release (due to creating the 1.4.0 tag), which included a source tarball, but then a few days later, @keithw manually created the "official" source tarball, and re-uploaded it to github, overwriting the old version. This lead to some minor confusion (see #1237 for example, and also some questions in IRC).
We should prevent this in the future. I think the steps we should follow is:
- git tag the release, and let Github Actions create the source tarball.
- Github Actions will create a release in "Draft" mode (already done, see here)
- Someone (Release Manager? Keith?) downloads the tarball and makes sure it looks OK (perhaps by comparing it against a locally generated tarball). If it's OK, then consider the tarball created by Github Actions to be the Official version
- Remove the "Draft" status from the dig
- (continue with the rest of the process, like sending out a pgp-signed announcement)
We should have a
RELEASING.mddocument that describes all of the steps needed to prepare and cut a new mosh release. The 1.4.0 release has shown that there were some gaps in our knowledge about how to do this :)cc @achernya @ezzieyguywuf @bbarenblat