search

mobile-shell / mosh

Mobile Shell
https://mosh.org
GNU General Public License v3.0
12.69k stars 741 forks source link

Use pipe to communicate between client and server at startup #1255

Closed ahedberg closed 1 year ago

ahedberg commented 1 year ago

Fixes #1142

cgull commented 1 year ago

Fixes #1142

I don't think this fixes anything? In the prior mosh-server code, that read/write on the pty are before any user data passes across it, the newline should never be seen by the user. The problems with excess newlines are in mosh.pl, at least in my experience.

I am concerned about the additional complexity added by this commit. At the very least, CLOEXEC should be set on the pipe fds.

achernya commented 1 year ago

that read/write on the pty are before any user data passes across it, the newline should never be seen by the user.

Empirically, it is being seen by the user.

achernya commented 1 year ago

@ahedberg I fixed the CI config, I believe if you rebase and push CI should be clean.