search

mobile-shell / mosh

Mobile Shell
https://mosh.org
GNU General Public License v3.0
12.59k stars 729 forks source link

configure.ac: add support of protobuf 4.22.x #1266

Closed chenxy1988 closed 1 year ago

chenxy1988 commented 1 year ago

the protobuf 4.22x is using c++14 as default, this caused the mosh cannot compile anymore and report following error:

.... /usr/include/google/protobuf/port_def.inc:200:15: error: static assertion failed: Protobuf only supports C++14 and newer. | 200 | static_assert(PROTOBUF_CPLUSPLUS_MIN(201402L), "Protobuf only supports C++14 and newer."); | | ^~~~~~ ....

achernya commented 1 year ago

Thanks for this PR, but we probably need to bump the entirety of mosh to a newer C++ standard, so I'm not sure right now if we'll merge this as-is. For existing distributions a local patch to enable a higher standards version will be needed.

chenxy1988 commented 1 year ago

Thanks for this PR, but we probably need to bump the entirety of mosh to a newer C++ standard, so I'm not sure right now if we'll merge this as-is. For existing distributions a local patch to enable a higher standards version will be needed.

Yes indeed, I fully understand with you, currently, lots of distributions might be using an old compiler, and perhaps too risky to impossible to upgrade stdcxx compiler to a newer version. We can turn this PR to a pending or close status and can re-open if mosh have a plan to support the cpp14 in the future, thanks :)

achernya commented 1 year ago

Mosh has been updated to C++17 in eee1a8cf413051c2a9104e8158e699028ff56b26