search

mobile-shell / mosh

Mobile Shell
https://mosh.org
GNU General Public License v3.0
12.59k stars 729 forks source link

Clang formatting traces #1319

Closed carloscabanero closed 5 months ago

carloscabanero commented 5 months ago

When applying the new formatting from our side, I noticed these three files (one line each), had been left over.

achernya commented 5 months ago

It looks like this PR fails our clang-format CI check. Which version of clang-format are you using?

carloscabanero commented 5 months ago

Yep, on those exact 3 lines. I'm running clang-format version 18.1.3. Just saw the pipelines are using version 14. Is there any reason for that? I gotta say the one liners with (x) looked better in the new. No worries then, feel free to close.

achernya commented 5 months ago

14 was the version that we did the initial clang-format with. We can upgrade, but haven't gotten around to it yet.

carloscabanero commented 5 months ago

I can try to help with that if you want me to. I'm in the middle of it from our side, and looks like it will only pull 3 simple changes in the repository.

achernya commented 5 months ago

Feel free to send us a PR bumping the clang-format version and doing the clang-format to all affected files!