search

mobile-shell / mosh

Mobile Shell
https://mosh.org
GNU General Public License v3.0
12.56k stars 730 forks source link

multipath mosh #712

Closed TimCook1 closed 1 year ago

TimCook1 commented 8 years ago

Out of curiosity, have boutier's changes/features been integrated into the mainline repo? If not, are there any plans to?

cgull commented 8 years ago

We'd like to take them, but the multipath code adds a few fields to the packet headers, making them incompatible with mainline Mosh. Nobody has yet figured out a good way to make this code interoperate with older versions of Mosh.

TimCook1 commented 8 years ago

Perhaps I'm being naive, but for the short term, couldn't you just put a field in to check server/client version on initial connect and default to the old behavior if you find it's an incompatible version? Then just deprecate the checking in a few versions?

Or, quite frankly, just keep the 1.x branch as a maintenance train only, move to a 2.x version number and tell people there's no backwards compatibility? I think the feature is compelling enough to make a break. And it wouldn't be the first time it's happened.

pavlix commented 7 years ago

Or, quite frankly, just keep the 1.x branch as a maintenance train only, move to a 2.x version number and tell people there's no backwards compatibility?

If that happens, it might be useful to add some feature discovery mechanism or protocol versioning mechanism to the protocol to avoid breaking compatibility again.

cgull commented 7 years ago

I think more in terms of making the protocol easily and efficiently expandable via option fields or demultiplexing, but yes, better forward compatibility would be a high priority for a v2.

achernya commented 1 year ago

https://github.com/boutier/mosh has substantially diverged from mainline mosh, and there's no PR. It's hard to tell which commits are important, and also it looks like it's incompatible with the existing mosh, which means we're not going to be able to consider it any time soon. Separately, we haven't evaluated if there's any benefits for multipath, so there's also that whole investigation.