search

mobileappdevhm / dev-team-1-cie-app-in-flutter

Development Team 01 (Flutter)
https://mobileappdevhm.github.io/dev-team-1-cie-app-in-flutter/
8 stars 1 forks source link

Bug which relates to department: null #217

Closed orb1005 closed 6 years ago

orb1005 commented 6 years ago

Unfortunately, the app still crashes when you didn't specify your department on nine. Explanation: I fill in my user credentials and click on "LOGIN" image

After that I land on the timetable page as expected image

If I then click on courses no courses will be shown image

A click on a different tab throws the error message image

Hope this helps. I assume that some of the other students didn't choose a department so we should fix this as soon as possible.

heatsink commented 6 years ago

I resolved this in https://github.com/mobileappdevhm/dev-team-1-cie-app-in-flutter/commit/c76f27cf9641806e7d5d64f462bdea109da07a3d

The cause of this is that Nine was returning Fakultät ## instead of just ## for departments, and the dropdown was using this to sort.

Thus the dropdown key was invalid, and the crash occurred. Temporary fix implemented to just trim the string from Nine, I'll implement a better fix later in our user builder so we don't have to worry about it.

orb1005 commented 6 years ago

@heatsink thank you for fixing this so fast

jusnelda commented 6 years ago

So it's still crashing for me... :-(

RedTo commented 6 years ago

There is different error if the curriculum returned by nine is null (-> user does not have set any department).

RedTo commented 6 years ago

Should be fixed with #221. Please check on the corresponding branch, or in master after it is merged and let me know if the problem still occurs on iOS.

I have decided to set the department to an empty string, so we do not need to set an default department. Maybe that is a good approach?!