mobileappdevhm / team2

A Flutter app providing international students with a timetable and the opportunity to sign up to courses.
https://mobileappdevhm.github.io/team2/
9 stars 5 forks source link

Settings page changes #146

Closed VoitreX closed 6 years ago

VoitreX commented 6 years ago

Just looking at the change log for now

VoitreX commented 6 years ago

Need to Fix tests in Add_Cie, CiE, and Profile!

Gleydar commented 6 years ago

I added a default initialisation for the UserSettings in the Session. Might actually not be good form, but I'll think of a nicer version to get default settings for a user thats not logged in soon-ish

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 670


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/connect/dataprovider/sqlite_provider_factory.dart 1 3 33.33%
lib/ui/scaffolds/course_details.dart 2 4 50.0%
lib/connect/dataprovider/cie/mock/sqlite_cie_provider.dart 0 3 0.0%
lib/ui/screens/add_cie_screen.dart 13 16 81.25%
lib/model/user/user_settings.dart 0 4 0.0%
lib/connect/dataprovider/user/mock/mock_user_settings_provider.dart 0 6 0.0%
lib/controller/session.dart 1 9 11.11%
lib/ui/screens/cie_screen.dart 13 21 61.9%
lib/connect/dataprovider/user/mock/sqlite_user_settings_provider.dart 0 13 0.0%
lib/ui/basic_components/rounded_button.dart 0 15 0.0%
<!-- Total: 76 284 26.76% -->
Files with Coverage Reduction New Missed Lines %
lib/ui/basic_components/scenery_widget.dart 1 93.2%
lib/ui/screens/timetable_screen.dart 2 79.17%
lib/connect/dataprovider/cie/mock/sqlite_cie_provider.dart 4 0.0%
lib/model/cie/cie.dart 7 0.0%
lib/connect/dataprovider/databasehelper/databasehelper.dart 11 0.0%
lib/ui/screens/settings_screen.dart 16 17.69%
lib/ui/scaffolds/login.dart 26 51.52%
lib/ui/screens/cie_screen.dart 59 13.58%
lib/ui/screens/add_cie_screen.dart 100 10.06%
<!-- Total: 226 -->
Totals Coverage Status
Change from base Build 623: -17.8%
Covered Lines: 702
Relevant Lines: 1849

💛 - Coveralls
Gleydar commented 6 years ago

Had to remove some tests, sadly.

Gleydar commented 6 years ago

I'm actually stupid and pushed the same changes to here as I did to #150