search

mobileappdevhm19 / HINT-Reader

apps4students-team-3 created by GitHub Classroom
Apache License 2.0
0 stars 0 forks source link

Make BookShelfView scrollable #33

Closed wildeKaiserin closed 5 years ago

wildeKaiserin commented 5 years ago

The horizontal bars should be scrollable as well as the whole view.

Kjani01 commented 5 years ago

Because of the smaller screen, I only implemented the most recent list in the horizontal BookShelfView. As soon as the View is scrollable, there should be more book suggestions to scroll through, as we see in de vertical BookShelfView.

ghost commented 5 years ago

Tables are not inherently scrollable, reworked into a Column of two GridViews, the main view vertical scrolling, the most recent horizontally. It's not pretty yet though - we need a divider of sorts between them. It is fully functional though (even though I don't know why it isn't loading the other image, but oh well)

screenshot WIP: https://i.imgur.com/3YnJ6d5.png

ghost commented 5 years ago

Integrated BookCards, now ready for review.

https://i.imgur.com/mppN0xR.png

wildeKaiserin commented 5 years ago

Review: All works, looks good. Well done! From my side, you can close the branch.

Kjani01 commented 5 years ago

Everything works fine and is scrollable like expected. I think we're done here and I'll close this issue. Well done!