mobileappdevhm19 / HINT-Reader

apps4students-team-3 created by GitHub Classroom
Apache License 2.0
0 stars 0 forks source link

Travis deploy release #41

Closed maxiking203 closed 5 years ago

maxiking203 commented 5 years ago

At the moment we are building the apk of our app on Travis but we don't store it somewhere. In future it should be stored as a release for example taged with "date-branchname".

maxiking203 commented 5 years ago

Travis is now deploying releases to GitHub. At the moment we are only doing this on the develop branch. We should do this on the master branch too. But the questions is, do we want the releases in the develop branch too or only in the master branch for the "real" releases?

maxiking203 commented 5 years ago

The deployment is "implemented" with an Personal access token which I added to my profil. This token is added as an env variable to Travis.

DManstrator commented 5 years ago

But the questions is, do we want the releases in the develop branch too or only in the master branch for the "real" releases?

Not sure if I get that right: Whenever somebody pushes to the develop branch, Travis would create a Release on GitHub. And we definitely push more often to the develop branch than to the master branch. So to reduce the amount of releases, we should only do it for the master branch then.

And as I know it from other projects, they also do that only for the master branch (or for a special beta branch if there is one) and not even there for every commit.

maxiking203 commented 5 years ago

@DManstrator you got it right. Normally in projects it only get done on the master branch, as I said I only did it for testing in the develop branch. But I wanted to get some opinions on how our team members would like it. Our process manager @pocketinfinity  also recommended that we only do it on the master so I will changed that later.

maxiking203 commented 5 years ago

The Releases are now only done on master branch. A updated Travis file is commited to master and develop branch. There a 3 Releases added to our repo which where for testing issues. This issue is read for Review. Have a look at the travis build log and the test releases.

Kjani01 commented 5 years ago

The apk is added to the release and the deploy is displayed in the Travis build log. Well done, Maxi!

wildeKaiserin commented 5 years ago

Review done, good job!