mobilecoinfoundation / mobilecoin

Private payments for mobile devices.
Other
1.16k stars 151 forks source link

Build Failure in mc-crypto-rand fallback #1074

Open tyurek opened 3 years ago

tyurek commented 3 years ago

Hey all, It appears that fallback.rs in mc-crypto-rand uses rand::rngs::adapter::ReseedingRng However, from rand v0.8.0 and onward, this is only available if the "std" feature is enabled. This resulted in a build failure for me at least, which was fixed by enabling the feature.

Thanks

jcape commented 3 years ago

Could you let us know the build command you were using? Were you trying to build the crate independently of other crates?

tyurek commented 3 years ago

Sure, I'm using the baiduxlab rust sgx sdk docker image (had to manually upgrade cargo) but I didn't specify a device. I was just playing around with ORAM and made a project which uses mc-fog-ocall-oram-storage-trusted and mc-fog-ocall-oram-storage-untrusted along with some mc-oblivious-ram code. Here's the Cargo.toml I was using, and I just ran my code with cargo run

[package]
name = "hello_world"
version = "0.1.0"
authors = ["root"]
edition = "2018"

[dependencies]
mc-oblivious-ram = "2.0.0"
aligned-cmov = "2.0.0"
mc-oblivious-traits = "2.0.0"
rand_core = "0.6.3"
rand_hc = "0.3.1"
mc-fog-ocall-oram-storage-trusted = { path = "../mobilecoin/fog/ocall_oram_storage/trusted" }
mc-fog-ocall-oram-storage-untrusted = { path = "../mobilecoin/fog/ocall_oram_storage/untrusted" }

[patch.crates-io]
schnorrkel-og = { git = "https://github.com/mobilecoinfoundation/schnorrkel.git", rev = "9b48418556b0af476be2313309bc5a23fb8b351d" }
ed25519-dalek = { git = "https://github.com/mobilecoinfoundation/ed25519-dalek.git", rev = "78bdc2a0b0af852cb4e47a0ca9be74bdf77c57b6" }

In the program itself, I have

use mc_fog_ocall_oram_storage_trusted::OcallORAMStorageCreator;
pub use mc_fog_ocall_oram_storage_untrusted::{
        allocate_oram_storage, checkin_oram_storage, checkout_oram_storage, release_oram_storage,
};
cbeck88 commented 3 years ago

@tyurek thanks for reporting, I'll look into this