search

mobilecoinfoundation / mobilecoin

Private payments for mobile devices.
Other
1.16k stars 148 forks source link

Create a CI test to find diverging dependencies #1742

Open jcape opened 2 years ago

jcape commented 2 years ago

An issue that appeared in #1732: the mc-fog-ocall-oram-storage-trusted crate appeared to require two different versions of blake2, depending on what platform it was built for. This is obviously wrong, so we should find or write a utility which will examine a Cargo.toml file and see if there are any dependencies with divergent versions, and wire that into CI so it will not allow this to be pushed.

cbeck88 commented 2 years ago

We might be able to use this script to find that?

https://github.com/mobilecoinfoundation/mobilecoin/pull/1388

jcape commented 2 years ago

Not it directly, my suspicion is that parsing Cargo.toml may be less effective in finding this type of issue vs. some form of awk | sort | egrep '([1-9][0-9]$| [2-9]$)', at least as long as we're still doing the terse dependency stanzas.