mobilecoinfoundation / mobilecoin

Private payments for mobile devices.
Other
1.16k stars 148 forks source link

More flexible memo builder #3200

Open cbeck88 opened 1 year ago

cbeck88 commented 1 year ago

One request we've had is that, we'd like to make it easier from a software interface point of view for teams like Moby to start using a new memo type in their app.

This ticket is for a more flexible memo builder for the type 1 authenticated memos.

Recall that, memos have 2 type bytes, and the first byte is a category, and the second byte is a type within the category.

The usecase we want to enable is that:

The proposed resolution is:

There was earlier discussion around this in MCIP 60

stevenspiel commented 1 year ago

How does one determine the next available second byte?

wjuan-mob commented 1 year ago

I think that our current design uses the mcips as the source of truth. You can reference https://github.com/mobilecoinfoundation/mobilecoin/blob/f8be8e7efd936de3eba85a9568005f7fbb5e9e30/transaction/extra/src/memo/mod.rs#L40 for types that have been provided inside mobilecoin, but as types are added by the moby team for example, those would be added in mcips.

cbeck88 commented 1 year ago

What we agreed in discussion around MCIP 60 is, you should still write an MCIP if you want to make a new memo and use it in production. You just don't need to wait for SDK or mobilecoin.git to do a release or anything before you can use it in flutter etc.