search

mobilecoinfoundation / sgx

SGX Libraries and Utilities
Apache License 2.0
9 stars 7 forks source link

Bring in `Ord` and `PartialEq` for `Report` #373

Closed nick-mobilecoin closed 11 months ago

nick-mobilecoin commented 1 year ago

IFF Report needs Ord and PartialEq we should bring in the logic from the MobileCoin repo as it was done to conform to a security audit.

https://github.com/mobilecoinfoundation/mobilecoin/blob/4dbbf0353078b94818358ef0ac10aa8d07394f0a/attest/core/src/report.rs#L80

At this time thinking this isn't needed, the only thing that was using Report with Ord was the NewEReportResponse which was removed in https://github.com/mobilecoinfoundation/mobilecoin/pull/3454

nick-mobilecoin commented 11 months ago

Closing as not needed, per

At this time thinking this isn't needed, the only thing that was using Report with Ord was the NewEReportResponse which was removed in https://github.com/mobilecoinfoundation/mobilecoin/pull/3454