Fixes for group cryptography issues

mobilecoinofficial / auxin

Developer friendly wrapper around the Signal Messenger protocol.

GNU Affero General Public License v3.0

8 stars 8 forks source link

Fixes for group cryptography issues #68

Closed NotGyro closed 2 years ago

NotGyro commented 2 years ago

Group cryptography issues appear to be fixed by these changes. A number of issues within Auxin have been fixed, and sanity checks have been added. Previously, identity keys were not being loaded correctly. Also, AuxinAddress equality comparisons required strict equality. Now, an AuxinAddress::Phone(phone_number_a) == AuxinAddress::Both(phone_numbera, ). Over-all, testing has shown this is reliable in situations where Auxin would have previously failed. More testing pending.

technillogue commented 2 years ago

code changes look good as far as I can tell, will try to test this with accounts that changed phone numbers and maybe see what it does in imogen groups soon TM

technillogue commented 2 years ago

got a one-off error after removing imogen dev from an old group: https://public.getpost.workers.dev/?key=01G1FMQT8A68HXJC6981437GSP&raw

but couldn't reproduce this in a new group