Closed transfaeries closed 2 years ago
transfaeries
commented
2 years ago all checks passed and removed all the codepaths I could find. since they were in hotline, I would feel better if Ilia looked over it to make sure I didn't break anything for her. Other than that, it should be good.
itdaniher
commented
2 years ago @transfaeries can you merge in the 'teddy' branch? I refactored yes/no a bit there....
transfaeries
commented
2 years ago I merged in teddy as requested. Removed obsolete codepaths. Changed some things for the better. added more negative and affirmative answers. Finally fixed MOST of the mypy and pylint errors, but I'm not sure how to fix the rest
itdaniher
commented
2 years ago this is a big UX win... will be trying to move hotline etc over in the immediate future!
Refactores ask_yesno_question to ask a freeform question and parse the answer, as opposed to having it's own functionality. This allows us to remove pending_confirmations, do_yes, do_no. It now allows for people to cancel, which returns None. This might break some flows so we can reconsider that, but I think it's good to allow people to say "actually no, I want out of here, not yes not no"
also now accepts answers that are not just "yes" and "no" like "y" "n" "yeah" etc.
Hopefully removed all the obsoleted codepaths, but please let me know if I missed anything.