search

mobilecoinofficial / forest

Enables a Forest of MobileCoin enabled SignalBots. Beta software, APIs may change!
MIT License
19 stars 12 forks source link

Unexpected behavior when sending reaction in groups #177

Closed deepfates closed 2 years ago

deepfates commented 2 years ago

When using self.send_reaction in DMs, it seems to work normally. However, when in groups, only the target author can see the reaction that the bot puts on their post. This is not the behavior i experience as a user of Signal Android or Desktop. Not sure if this is a bug in the Signal class, or an rpc error, or something in the underlying signal-cli.

technillogue commented 2 years ago

this seems like it might be a bug with signal-cli, we should test signal-cli sendReaction directly w/o jsonrpc

technillogue commented 2 years ago

https://github.com/mobilecoinofficial/forest/blob/main/forest/core.py#L496

        cmd = rpc(
            "sendReaction",
            param_dict=react,
            emoji=emoji,
            recipient=target_msg.source,
        )

lol we only ever send it as a DM, clients just magically figure out what message it's actually reacting too...

technillogue commented 2 years ago

should be closed now