Closed holtzman closed 4 months ago
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 55.60%. Comparing base (
ab2af32
) to head (af95b6e
). Report is 194 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
full-service/src/json_rpc/v2/api/wallet.rs | 50.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
In order to keep a
view-only
account's balances in sync with activity happening on the account outside of this instance of full-service, one can:create_view_only_account_sync_request
to obtain a list of txos for which theview-only
account does not know the corresponding key imagessync_view_only_account
request that associatestx_out_public_keys
with their correspondingkey_images
, andsync_view_only_account
request to the full-service with theview-only
account.The
txo_sync_request
generated in response to thecreate_view_only_account_sync_request
method is supposed to include the account_id of theview-only
account. This helps ensure that thetx_out_public_keys
are processed with the correct account keys when generating thekey_images
Prior to this PR, the account_id returned was all zeros.
In this PR
create_view_only_account_sync_request
to include the actualaccount_id
of theview-only
account, instead of generating an all-zeros placeholderaccount_id
.