mobilecoinofficial / full-service

A MobileCoin service for wallet implementations.
Other
46 stars 21 forks source link

convert hex encloded account_id to AccountId instead of using zeros #992

Closed holtzman closed 6 months ago

holtzman commented 6 months ago

Motivation

In order to keep a view-onlyaccount's balances in sync with activity happening on the account outside of this instance of full-service, one can:

The txo_sync_request generated in response to the create_view_only_account_sync_request method is supposed to include the account_id of the view-only account. This helps ensure that the tx_out_public_keys are processed with the correct account keys when generating the key_images

Prior to this PR, the account_id returned was all zeros.

In this PR

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.60%. Comparing base (ab2af32) to head (af95b6e). Report is 194 commits behind head on main.

Files Patch % Lines
full-service/src/json_rpc/v2/api/wallet.rs 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #992 +/- ## ========================================== - Coverage 60.12% 55.60% -4.53% ========================================== Files 88 124 +36 Lines 12356 16289 +3933 Branches 2010 2799 +789 ========================================== + Hits 7429 9057 +1628 - Misses 3238 5146 +1908 - Partials 1689 2086 +397 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.