Closed holtzman closed 6 months ago
Attention: Patch coverage is 0%
with 85 lines
in your changes are missing coverage. Please review.
Project coverage is 55.38%. Comparing base (
ab2af32
) to head (e7594fe
). Report is 196 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
signer/src/service/api/mod.rs | 0.00% | 49 Missing :warning: |
signer/src/service/mod.rs | 0.00% | 30 Missing :warning: |
signer/src/service/api/request.rs | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
Offline signers have expressed a desire to store and manage the secret entropy of their account as a 32 byte value rather than as a 24 word mnemonic phrase for consistency with other blockchain wallets that their software manages this way.
Herein we introduce
bip39_entropy
, a 32 byte, hex-encoded string (64 characters) to thesigner-service
API to satisfy this need. When outputting account keys, signing txos, or syncing txos for aview-only
wallet, users of thesigner-service
can now chose between providing a 24 word phrase,mnemonic
, or a 64 character hex-encoded 32 byte secret, usingbip39_entropy
.In this PR
mnemonic
optional and to optionally allowbip39_entropy
.mnemonic
orbip39_entropy
and to use whichever is provided.