mobilecoinofficial / full-service

A MobileCoin service for wallet implementations.
Other
46 stars 21 forks source link

Introduce webhook callback in account sync #998

Closed sugargoat closed 3 months ago

sugargoat commented 3 months ago

Motivation

Some ramps providers would like to receive a callback when TXOs are found for their accounts during syncing.

In this PR

Test Plan

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.36697% with 21 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (ab2af32) to head (e9f6715). Report is 202 commits behind head on main.

Files Patch % Lines
full-service/src/service/webhook.rs 70.21% 6 Missing and 8 partials :warning:
full-service/src/config.rs 0.00% 6 Missing :warning:
full-service/src/service/sync.rs 95.45% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #998 +/- ## ========================================== - Coverage 60.12% 55.66% -4.46% ========================================== Files 88 125 +37 Lines 12356 16509 +4153 Branches 2010 2832 +822 ========================================== + Hits 7429 9190 +1761 - Misses 3238 5222 +1984 - Partials 1689 2097 +408 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sugargoat commented 3 months ago

This PR is now ready for review, and I would recommend that we leave the restart logic for a fast follow.