search

mobilecommons / google_civic_info

Ruby client for Google Civic Information API
MIT License
1 stars 1 forks source link

Restyle code to match ruby style guide #5

Open walter opened 10 years ago

walter commented 10 years ago

Would you be open to restyling the codebase to match https://github.com/styleguide/ruby? I find this corresponds pretty closely to mainstream ruby coding and it helps to have something to refer to when on boarding new team members.

I'm open to doing the work.

Cool, if not. Just close this if you would rather stay with your existing style.

benstein commented 10 years ago

Sure!

On Tue, Nov 26, 2013 at 5:03 PM, Walter McGinnis notifications@github.comwrote:

Would you be open to restyling the codebase to match https://github.com/styleguide/ruby? I find this corresponds pretty closely to mainstream ruby coding and it helps to have something to refer to when on boarding new team members.

I'm open to doing the work.

Cool, if not. Just close this if you would rather stay with your existing style.

— Reply to this email directly or view it on GitHubhttps://github.com/mobilecommons/google_civic_info/issues/5 .

Benjamin Stein 646-221-1189 Me: http://benjaminste.in Boys: http://gabrielste.in http://ezekielste.in Work: http://mobilecommons.com

walter commented 10 years ago

I have some bigger fish to fry first, but probably get to it either end of this week or next.

Would make my life simpler if you accepted #3 first.

walter commented 9 years ago

I've decided I needed enough changes (and quickly) to just run with my fork. However I did end up restyling things.

https://github.com/walter/google_civic_info/commits/master

You are welcome to grab whatever you want. Sorry I didn't bundling things up into nice pull requests.