Add versioned bucket support to empty-bucket.js

mobileposse / auto-delete-bucket

Custom resource for automatically deleting S3 bucket contents when the stack deletes

MIT License

45 stars 18 forks source link

Add versioned bucket support to empty-bucket.js #4

Closed jwmonroe-outschool closed 4 years ago

jwmonroe-outschool commented 4 years ago

Does what it says on the box.

I did some basic testing on AWS:

un-versioned bucket with un-versioned objects
versioned bucket with all un-versioned objects
versioned bucket with versioned and un-versioned objects
versioned bucket with versioned objects, deleting some

schof commented 4 years ago

Thanks for the contribution. Have you tested this in a bucket without versioning to make sure that it still works?

jwmonroe-outschool commented 4 years ago

Yes, I ran yarn cdk:deploy on the default stack, uploaded a few files to the bucket, and then ran yarn cdk:destroy and verified it deleted the buckets

jwmonroe-outschool commented 4 years ago

@schof pinging since I'm sure if you saw my comment above