search

mobileposse / auto-delete-bucket

Custom resource for automatically deleting S3 bucket contents when the stack deletes
MIT License
45 stars 18 forks source link

Feature request: Versioned buckets #5

Open Dzhuneyt opened 4 years ago

Dzhuneyt commented 4 years ago

It would be great to empty also versioned buckets before they are removed.

Thank you for the amazing library!

AlexCheema commented 4 years ago

+1 It looks like there was a commit for this, but it does not work. It would simply require fixing the lambda to properly empty a versioned bucket before deleting.

AlexCheema commented 4 years ago

Any news on this? @BDQ @schof Would be good to support versioned buckets :+1:

schof commented 4 years ago

@Dzhuneyt I'm not using versioned buckets so I don't really have the expertise to fix this. Happy to accept a PR from you or anyone else though!