Open felixkluge opened 3 months ago
Please note that formatting did some additional changes in gsd/evaluation.py
Tests still to be added - any suggestions?
@a-mosquito Can you have a look at this? In particular considering the changes that you made for error calculation. Do you see a way this could be integrated better with the other error calculation stuff?
It should be possible to integrate that to the syntax introduced by #126. We could model the performance index calculation as a chain of transformations & aggregations:
apply_transformations
. apply_aggregations
.Some considerations for the practical side of implementing this:
criterion
and normalization
as args, which would require wrapping them in a (named) lambda for modifying the args; or split them into several functions for each possible configuration. I think the latter would be easier, because currently, only the configurations criterion="benefit"
; normalization= None
and criterion="cost"
; normalization="exponential"
are used, which would require only two default normalization functions.
Added performance index calculation as discussed in https://github.com/mobilise-d/mobgap/issues/122