mobility-team / mobility

Mobility, an open-source library for mobility modelisation
MIT License
16 stars 10 forks source link

Add numeric_only arg to pandas sum to avoid an error #60

Closed FlxPo closed 1 year ago

FlxPo commented 1 year ago

Règle https://github.com/mobility-team/mobility/issues/57

La nouvelle version de pandas 2.0 renvoie maintenant une erreur lorsqu'on essaie de sommer une colonne non numérique (ici une colonne de type datetime). Il faut maintenant expliciter l'argument numeric_only=True.

Nos versions en local utilisent sûrement encore pandas 1.5, mais la procédure de test installe la dernière version de pandas (donc la 2.0), d'où la différence de comportement.

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (a74118c) into main (21033ae) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   94.76%   94.80%   +0.03%     
==========================================
  Files          10       10              
  Lines         497      500       +3     
==========================================
+ Hits          471      474       +3     
  Misses         26       26              
Impacted Files Coverage Δ
mobility/parsers/emp_2019.py 99.47% <100.00%> (ø)
mobility/parsers/entd_2008.py 99.33% <100.00%> (ø)
mobility/trip_sampler.py 88.73% <100.00%> (+0.49%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more