mobility-team / mobility

Mobility, an open-source library for mobility modelisation
MIT License
16 stars 10 forks source link

Departments radiation functions are now main functions #76

Closed Mind-the-Cap closed 1 year ago

Mind-the-Cap commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (dd232d4) into main (4d3b4c2) will decrease coverage by 0.32%. The diff coverage is 90.80%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   95.32%   95.00%   -0.32%     
==========================================
  Files          13       19       +6     
  Lines         556      961     +405     
==========================================
+ Hits          530      913     +383     
- Misses         26       48      +22     
Impacted Files Coverage Δ
mobility/parsers/job_active_population.py 70.96% <33.33%> (ø)
mobility/radiation_departments.py 94.55% <94.55%> (ø)
mobility/get_insee_data.py 100.00% <100.00%> (ø)
test/test_radiation_model.py 100.00% <100.00%> (ø)
test/test_trip_sampler.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

FlxPo commented 1 year ago

OK pour moi pour le moment, mais je pense qu'il faudra à terme extraire un maximum de fonctions génériques réutilisables de radiation_departments, notamment :

Mind-the-Cap commented 1 year ago

@FlxPo merci pour la review. Très juste pour la réintégration des calculs dans un fichier plus global, je note de faire ça.