search

mobilityhouse / ocpp

Python implementation of the Open Charge Point Protocol (OCPP).
MIT License
766 stars 298 forks source link

Drop support for Python 3.7 #565

Closed OrangeTux closed 7 months ago

OrangeTux commented 8 months ago

Python 3.7 reached End of Life. Therefore, we can stop testing against this version.

We should:

  1. remove Python 3.7 from our workflow.
  2. raise the minimum Python supported Python version to 3.8
  3. remove the dependency on asynctest That fixes #433
  4. Remove Python 3.7 classifier from pyproject.toml
MuhammadHasnain77 commented 8 months ago

I have remove the version 3.7 from workflow check it out also can you explain the other two issue

OrangeTux commented 8 months ago

Among other things, pyproject.toml lists all dependencies of this project. That includes the Python version(s) that are supported by this project.

That file must be modified so minimum supported Python version is raised from Python 3.7 to Python 3.8. Read more at Poetry's documentation about dependency specification.

asynctest is a dependency required when using this project with Python 3.7. For all new Python version, this dependency is not required anymore. Since we drop support for Python 3.7, we can also remove the dependency asynctest completely. Here you can read more on restricting dependencies to specific Python version

MuhammadHasnain77 commented 8 months ago

Thanks for describing the issue I will work on it.

Jared-Newell-Mobility commented 7 months ago

Additional work to date can be found in https://github.com/mobilityhouse/ocpp/pull/475

MuhammadHasnain77 commented 7 months ago

Hi Can you see my PR did i correct all the issues?

Jared-Newell-Mobility commented 7 months ago

Associated PR https://github.com/mobilityhouse/ocpp/pull/585

Jared-Newell-Mobility commented 7 months ago

PR https://github.com/mobilityhouse/ocpp/pull/585 created and approved for inclusion in v1.0.0 - so closing issue