mobilutz / ioBroker.freeathome

Adapter to include free@home into ioBroker.
MIT License
12 stars 5 forks source link

Think about to fix the issues found by adapter checker #20

Open ioBrokerChecker opened 4 years ago

ioBrokerChecker commented 4 years ago

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:

https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/mobilutz/ioBroker.freeathome

I have also found warnings that may be fixed if possible.

Thanks, your automatic adapter checker.

P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

ioBrokerChecker commented 3 years ago

Do you need help fixing the bugs?

guerda commented 2 years ago

@mobilutz : It looks like this can be closed, can't it? I only see repository and travis missing. What do you think?

Apollon77 commented 2 years ago

BTW: Replace travis by GitHub actions please :-)) Travis is no longer that good

guerda commented 2 years ago

Lutz already implemented Github actions: https://github.com/mobilutz/ioBroker.freeathome/actions/workflows/nodejs.yml Would it be possible to check for either Travis or Github actions?

Apollon77 commented 2 years ago

Yes the checker will be adjusted

Apollon77 commented 2 years ago

PS: But the testing is not executing the adater tests ... so it would not be sufficient :-) Additionally best practice it to also run tests on windows, linux and maos - unless adapter is limited to one of those ...

Maybe refer to the "standard" github actions from adapter-creator like https://github.com/ioBroker/ioBroker.example/blob/master/JavaScript/.github/workflows/test-and-release.yml ... they would also allow to automate the release process with the release script and much more :-)