search

mobily / ts-belt

🔧 Fast, modern, and practical utility library for FP in TypeScript.
https://mobily.github.io/ts-belt
MIT License
1.1k stars 30 forks source link

added test to ensure benchmark is correct #22

Closed Pyrolistical closed 2 years ago

Pyrolistical commented 2 years ago

The benchmark wasn't quite correct as some libs weren't even producing the same result.

I wrote a test compare the output of each benchmark to ts-belt.

I fixed the following issues

  1. removed rambda flat test as their flatten is only a deep flatten
  2. removed lodash/fp sort as their comparator api is different than the one being provided
  3. fixed the ordering of zip for various libs
Pyrolistical commented 2 years ago

@mobily i think you might have accidentally re-added the lodash sortBy when merging https://github.com/mobily/ts-belt/pull/22/commits/08c3d123685a2907296aea2a111882e95437280f

mobily commented 2 years ago

oh, that's right, I'll remove it