search

mobius-looper / mobius

Other
17 stars 5 forks source link

64-bit Compatibility #2

Closed krawumski closed 6 months ago

krawumski commented 1 year ago

Hello! So now that Claudio has submitted the first pull request, I'm wondering if I should also submit one for my 64-bit build. It will be big but I guess that's what it takes. Any thoughts?

ClaudioCas commented 1 year ago

Hi Krawumski, thanks for your effort! I think you should fork the git repo and push your changes on it first. Probably we can make a branch for 64bit version.

cllunsford commented 1 year ago

I've pushed up my working branch for the 64-bit migration and opened an MR, as well. I'm happy to take edits on that or I can merge my changes into your build if you're feeling confident with the status of your build.

ClaudioCas commented 1 year ago

Dear Chris, thanks a lot for your work! I will try to compile it asap :)!

ClaudioCas commented 1 year ago

Hi Chris, I post my feedback here. I have an audio problem in the 64bit version. In particular glitches every beat of bar and I have asynchronism with vst host clock, the audio loop tends to speed up and in the debug window (with trace level 3) I have messages that talk about "Output buffer not fully consumed". immagine

I trace also the values of getRemainingFrames() and I have always the same value (192 in my case). Probably some variables should set to 32bit and now is 64bit immagine

cllunsford commented 1 year ago

There was an error in the deltaFrames function in the version I pushed previously. I've corrected the pointer diff types and pushed a new commit.

cllunsford commented 6 months ago

64-bit support has been merged into the master branch. I'll be cutting the 2.5.1 release soon.