mobiusklein / ms_deisotope

A library for deisotoping and charge state deconvolution of complex mass spectra
https://mobiusklein.github.io/ms_deisotope
Apache License 2.0
33 stars 14 forks source link

Pyteomics version pinning in setup.py #30

Closed joewandy closed 11 months ago

joewandy commented 11 months ago

Hi @mobiusklein, hope you're doing well.

For ms_deisotope 0.0.53, I noticed pyteomics is pinned to 4.6.0 in setup.py https://github.com/mobiusklein/ms_deisotope/blob/master/setup.py#L277

But the latest version of pyteomics (4.6.2), released 3 weeks ago, seems to have fixed a number of issues that you raised. Is it now possible to remove that version pinning so we can install pyteomics 4.6.2 alongside ms_deisotope?

Thanks, and have a nice day!!

Joe

mobiusklein commented 11 months ago

Version 0.0.53 is now live on PyPI (https://pypi.org/project/ms-deisotope/) that should allow pyteomics>=4.6.2

joewandy commented 11 months ago

Thanks a lot!!