search

mobiusklein / ms_deisotope

A library for deisotoping and charge state deconvolution of complex mass spectra
https://mobiusklein.github.io/ms_deisotope
Apache License 2.0
33 stars 14 forks source link

Creating a release of ms_deisotope #6

Closed azzamallow closed 4 years ago

azzamallow commented 5 years ago

Hello!

Just for some context, I have been working with @infusini to get ms_deisotope working for our project.

I have been working off master, though I noticed there have been commits going into master. This introduces a problem for me. I automatically checkout and build ms_deisotope, and without a release/tag there is a risk that I will be checking out new changes which may break how I use ms_deisotope.

Are you able to create a release and/or tag a version of ms_deisotope? This will allow me to checkout that version and know it is consistent, and gives me the flexibility to opt-in to new changes that you create.

Thanks for your time!

mobiusklein commented 5 years ago

I should be able to do that. I'll add a tag tomorrow morning. Is anything currently broken for you that I should fix before then?

I'm just finishing up a small patch to make tracking co-isolation possible and then I'll likely be leaving things alone for a bit. I also should learn to stop working off master now that I have people using the library.

I'll also be pinning the required pyteomics version because a 4.0 release is pending that will break everything.

azzamallow commented 5 years ago

Great @mobiusklein, we'll keep an eye out for the changes. And there is nothing broken as far as I know, its more of a precautionary thing for us!

Appreciate the quick reply, take care.

mobiusklein commented 5 years ago

You should be able to use Tag v0.0.6 which marks 2c6f51aa64b94330753d8110680baae333f6ad7b, the last set of commits for this pending work set.

I'll try to do a PyPI release soon.