search

mobiusklein / ms_peak_picker

A small library to provide peak picking for software processing mass spectrometry data
20 stars 8 forks source link

stop picking if there are no peaks after transforming #4

Closed heckendorfc closed 6 years ago

heckendorfc commented 6 years ago

Empty scans cause errors further down the call chain and it means there's nothing to pick anyway.

mobiusklein commented 6 years ago

Odd, I thought I had already fixed this.

Semantically, I don't know if returning None is a good idea here. It would make more sense to return an empty PeakIndex, so that the caller doesn't have to check for None before invoking methods. For the moment, I'll merge this and try to decide which route works better for the future.