Open vijayvarma392 opened 1 year ago
On a similar note, in this page: https://moble.github.io/PostNewtonian.jl/dev/interface/high-level/#.-Compute-the-waveform, shouldn't h[1, :]
correspond to the (2,-1) mode?
This page https://moble.github.io/PostNewtonian.jl/dev/internals/dynamics/#Approximants says TaylorT4 and TaylorT5 are available, but I'm getting errors like:
Relatedly, it would be good to have the defaults for these parameters in the documentation:
For example, is an array format ok for the Rotor, or does it need to be a quaternionic object or some such?
If this is int, how does one enter half integers like 3.5?
Also, do we want to make PN orders for phasing and spins available as separate options?
I like that t=0 is set to the time where Omega=Omega_i, so that if Omega_1 < Omega_i, negative times correspond to earlier frequencies. But this should be noted in the docs of https://moble.github.io/PostNewtonian.jl/dev/internals/dynamics/
For the returned variables in https://moble.github.io/PostNewtonian.jl/dev/internals/dynamics/, is it possible to add a _to_dict()
option so that the variables can also be accessed by name in Python? I see a way to do that in Julia, but not in Python at the moment.
The docs should also say what waveform convention we use...it looks like the old SpEC convention? Should we switch to the new one with the minus sign?
In this page: https://moble.github.io/PostNewtonian.jl/dev/internals/waveforms/#PostNewtonian.coorbital_waveform, the link
"Waveforms" section of the manual.
gives a File not found error.