Closed elaine-ran closed 4 months ago
Almost working. Should be easy to get the last errors fixed, but I have to run for now. Here's what I've done so far:
var_collect
— which is a critical piece of @pn_expansion
— depends on Symbolics. For now, I'll just pretend the the extension is a normal file, in hopes of being able to change it to a real extension sooner than later.main
since you started your fork, so I've rebased your changes.type_converter(::PNSystem{T}, x) where {T<:Vector{Symbolics.Num}}
) don't need to be documented again if they just extend a function that was already documented in the main code.unhold
to the extension along with hold
.𝓔′
to 𝓔′Symbolics
to avoid conflictsPostNewtonian
itself, and MacroTools
.Attention: Patch coverage is 64.28571%
with 30 lines
in your changes missing coverage. Please review.
Project coverage is 82.50%. Comparing base (
865de96
) to head (689dba7
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ext/PostNewtonianSymbolicsExt.jl | 38.09% | 26 Missing :warning: |
src/systems.jl | 87.50% | 2 Missing :warning: |
src/utilities/macros.jl | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks Elaine! Nice work!
FastDifferentiation.jl
is much faster thanSymbolics.jl
and the executables made byFastDifferentiation.jl
are also faster, change𝓔′
from usingSymbolics
toFastDifferentiation
. Resolves issue #26 ! a. This required the addition of a type ofPNSystem
, calledFDPNSystem()
which stores its state variables asFastDifferentiation.Node
s.FDPNSystem()
must be initialized with a float type (ex.FDPNSystem(Float64)
).binding_energy.jl
test file to test𝓔′
usingFDPNSystem(Float64)
instead ofSymbolicPNSystem()
.PostNewtonianSymbolicsExt.jl
.