search

moble / PostNewtonian.jl

Orbital dynamics and waveforms for binary black-hole systems, in the post-Newtonian approximation
MIT License
13 stars 0 forks source link

CompatHelper: bump compat for SymbolicUtils in [weakdeps] to 3, (keep existing compat) #57

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 2 months ago

This pull request changes the compat entry for the SymbolicUtils package from 1, 2 to 1, 2, 3. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

moble commented 2 months ago

This just has to wait for JuliaSymbolics/Symbolics.jl#1196, which was waiting for https://github.com/SciML/SymbolicLimits.jl/pull/10, though that's now merged, so it should be good to go.

Should simultaneously expand the Symbolics compat to v6.

moble commented 1 month ago

The failure is because the new version of DataInterpolations that explicitly allows Symbolics v6 and SymbolicUtils v3 is not out yet, and CompatHelper PRs automatically try to install the newest of everything. Running the tests locally, after doing add DataInterpolations#main lets the tests pass, though. So I'll just merge this for now, since no one will actually run using the CompatHelper flag.