moble / scri

Python/numba code for manipulating time-dependent functions of spin-weighted spherical harmonics on future null infinity
MIT License
18 stars 20 forks source link

waveform_grid and asymptotic_bondi_data transform differently #87

Closed keefemitman closed 1 year ago

keefemitman commented 1 year ago

It seems that when transformed via a supertranslation, waveform_grid and asymptotic_bondi_data objects transform somewhat differently. I haven't dug through the code, but it looks the relationship between the transformations that map to the same frame are \alpha(waveform_grid)=4\alpha(asymptotic_bondi_data). I assume this is due to a convention choice? E.g., using a NP definition instead of a GHP definition for \eth operators or something.

moble commented 1 year ago

Closed by 73fd2052299314de5b3dc3da11f605b2a51b9675, which appeared in https://github.com/moble/scri/releases/tag/v2022.8.6. I also added a pretty thorough test here.

keefemitman commented 1 year ago

Nice! Thanks Mike!