Add 2nd monotonic requirement; fixes subtle bug affecting some CCE outputs

moble / scri

Python/numba code for manipulating time-dependent functions of spin-weighted spherical harmonics on future null infinity

MIT License

18 stars 20 forks source link

Add 2nd monotonic requirement; fixes subtle bug affecting some CCE outputs #93

Closed keefemitman closed 5 months ago

keefemitman commented 5 months ago

@moble should be an easy review; fixes a bug that occurs when the output CCE data has time steps with differences ~1e-15, which are set to zero when doing -= float(radius) and screw up the monotonicity of the time array.

keefemitman commented 5 months ago

@moble not sure why the latest commit is causing test_supertranslation_inverses to fail... none of the code changed is relevant to that function... is something I should investigate?

moble commented 5 months ago

I just made a commit that I thought should solve it, but I now realize won't do anything at all. In any case, this is possibly a bad test, and the failure certainly unrelated to this commit, so I'll just merge this and deal with any failures later. (Maybe I'll just disable the test if it keeps happening.)