moble / scri

Python/numba code for manipulating time-dependent functions of spin-weighted spherical harmonics on future null infinity
MIT License
18 stars 20 forks source link

transition_times for corotating frame? #97

Open vijayvarma392 opened 2 months ago

vijayvarma392 commented 2 months ago

There is an option to use transition_times for corpecessing frame to avoid ringdown issues: https://github.com/moble/scri/blob/544f481b65a00d08271d2faa53908df64e054fc6/scri/rotations.py#L27

Should we be worried about the same thing for corotating frame? I think no, but just want to check.

In any case, we should have transition_times in the sxs version of to_coprecessing_frame as well: https://github.com/sxs-collaboration/sxs/blob/main/sxs/waveforms/waveform_modes.py#L1178. Didn't want to raise two issues, so :)