search

mobnetic / BitcoinChecker

DataModule for Bitcoin Checker android app
340 stars 213 forks source link

Binance parsing error #931

Open awaisaliliaqat opened 4 years ago

awaisaliliaqat commented 4 years ago

Error: Parsing error Binance Bitcoin

ErikAbele commented 4 years ago

Yes, I can second that: since yesterday night all pairs of Binance are throwing a parsing error.

Would be greatly appreciated if that could be fixed – thank you in advance!

die4kill4 commented 4 years ago

The problem seems to be related to the Binance changing his public API. And since the app seems to be abandoned by the developer long ago there is noone to fix it. What a pity! Two years it was working on my phone without a hitch. And it is very hard to find a suitable alternative.

die4kill4 commented 4 years ago

Just saying: I would pay to have a working version of Bitcoin checker/

ErikAbele commented 4 years ago

The problem seems to be related to the Binance changing his public API. And since the app seems to be abandoned by the developer long ago there is noone to fix it. What a pity! Two years it was working on my phone without a hitch. And it is very hard to find a suitable alternative.

Oh, did he really abandon it? I would be able to look into it if the dev would be fine with merging that into a new release then... I've just sent him an email.

die4kill4 commented 4 years ago

Oh, did he really abandon it?

Well, I guess, I do not know for sure, but it's free app for niche audience. I can see how he may decide to move on and find another use for his skills.

Kerbox2000 commented 4 years ago

That is too bad, this a great app and a great help to me, I have been using this for years without problems but now I am experiencing this same problem when choosing Binance.

die4kill4 commented 4 years ago

Just saying: I would pay to have a working version of Bitcoin checker/

Just sent 10$ in bitcoin as a "thank you" for the great app

bullionstar commented 4 years ago

Binance Bitcoin parsing error, please fix. Thank you

ikt commented 4 years ago

Oh, did he really abandon it? I would be able to look into it if the dev would be fine with merging that into a new release then... I've just sent him an email.

I've sent an email a week ago as well with no response and the app is literally no longer listed on the play store...

If you need a beta tester I'm happy to put my hand up, running a pixel 2 latest version of Android

khenn00 commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

ErikAbele commented 4 years ago

It works again!

Oh and to all others: do NOT install some random APK – it might contain something you certainly do not want on your mobile phone... just be cautious!

motogscs commented 4 years ago

Unfortunately, same mistake again today and constant

Aspersat commented 4 years ago

If the project is abandoned why don't we fork it, fix it and release it new. I'm not a guru but the code looks good. We should try to look for a dev. I'll ask a friend of mine. It looks that if only needs some adjustments in the data module for some of the exchanges.

ikt commented 4 years ago

@Aspersat the problem is that he hasn't specified a licence https://github.com/mobnetic/BitcoinChecker/issues/119

Someone needs to do some movie style tracking and get ahold of the guy

khenn00 commented 4 years ago

Like I said in my previous comment this already have a pull request but doesnt get updated. I already put the download link there but if you're like @ErikAbele that cant trust any random apk then goodluck for the wait and your phone will be always safe for hackers.

Aspersat commented 4 years ago

Contacted the guy on LinkedIn lets see. Would be grat if we could convince him to add a License that allowes us to legaly fork the project. or Convince him of handing the project over to a still active contributor.

echomaestro commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

It works, but not all pairs are available. I can't find BTC/NGN or BTC/BUSD

rodrigoslayertech commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

This version is safe? Does not have any malware?

Aspersat commented 4 years ago

We don't know. I would not trust it

khenn00 commented 4 years ago

@slowaways if you cant trust it , you can just do it yourself . its pretty easy with a bit of googling , just insert this pull request to the code .

GitToLife commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

Worked thanks ! Guys, if you worry about malware just turn off all the permissions.

GitToLife commented 4 years ago

By the way, anyone knows the reason this app got removed from Play Store ?

presence35 commented 4 years ago

I tried looking at the code. I'm not a Java developer and this project is pretty big. I couldn't find the problem. The JSON object that gets the bid & ask prices (etc) still correspond with Binance's API...so I'm not sure where the problem is exactly. If I knew Java I could return the full error and go from there.

This is the call...everything looks fine.

https://api.binance.com/api/v1/ticker/24hr?symbol=BTCUSDT

ikt commented 4 years ago

I tried looking at the code. I'm not a Java developer and this project is pretty big. I couldn't find the problem. The JSON object that gets the bid & ask prices (etc) still correspond with Binance's API...so I'm not sure where the problem is exactly. If I knew Java I could return the full error and go from there.

This is the call...everything looks fine.

https://api.binance.com/api/v1/ticker/24hr?symbol=BTCUSDT

I'm not a java developer either but looking at

https://github.com/mobnetic/BitcoinChecker/issues/931#issuecomment-657226619

The pull request diff makes a simple change, it now checks for "Content-Encoding" or "content-encoding", instead of assuming that it will be offered as "Content-Encoding".

Should probably just do the merge myself but damn that would suck to have to side load.

rodrigoslayertech commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

This version break the automatic update. I have to update the ticket manually.

Kerbox2000 commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

Hey @khenn00 , I tried this out and it works just great, I really appreciate it!

echomaestro commented 4 years ago

Pls someone should add all the fiat pair. I can't find NGN market pairs like BUSD/NGN

ikt commented 4 years ago

Any luck contacting the lead dev @Aspersat ?

echomaestro commented 4 years ago

This also happen in kraken, see #895 , its been fixed and have pull request , I got tired of waiting and did a bit of googling and manage to fixed it. download here .

Can you please add other fiat markets. Its only USDT that is available.

aneonex commented 4 years ago

Good news!

Launched new version of Bitcoin Checker:

Whats new (v2.3):

Additional notes:

Latest updates see on Github: https://github.com/aneonex/BitcoinChecker/

ErikAbele commented 4 years ago

@aneonex Nice, thank you for your work on this!