mobomo / lark

A Drupal 8 administration theme by Mobomo
2 stars 2 forks source link

Cleaning up content type display ui and views-exposed-form styling #83

Open briancoffelt opened 3 years ago

briancoffelt commented 3 years ago

I was assigned two PRAC tickets to address styling issues with the admin theme. I submitted fixes to allow space between the content type display form and its buttons as well as exposed filter styling on the main media content page. Here's the descriptions from the Jira tickets:

PRAC-887 Admin Button spacing should be consistent Some buttons are flush up with other ui elements causing confusion.

/admin/structure/types/manage/article/display has a single "Manage Layout: button at the top of the form with a whitespace issue where it is flush up against the underline of the selected tab “Default.” It should have the same default whitespace as other buttons. We need to find out if we the culprit here is in the lark theme, the prac theme, or just the Drupal default layout manager button spacing is somehow bad to begin with.

We then need to set the correct spacing to be applied so it looks consistent with other pages.

We also need to consider that maybe in the case of more than one button they should stack horizontally instead of vertically, which might mean taking an inventory of all admin pages and seeing which ones have stacking in which directions.

Acceptance criteria: The button spacing at the top of the form underneath the tabs should match between these two pages /admin/structure/types/manage/article/display /admin/structure/types/manage/article/fields.

PRAC-1239 "Filter" button is offset URL: /admin/content/media all environments

Browser: Chrome

Behavior: When user is at /admin/content/media, "Filter" button is offset with other fields.

Acceptance criteria: "Filter" button under media is in-line with other fields.