search

mobxjs / mobx-angular

The MobX connector for Angular.
MIT License
483 stars 59 forks source link

Remove spread operator from module declaration (#112) #113

Closed kubk closed 4 years ago

kubk commented 4 years ago

Make mobx-angular compatible with Angular 9 by removing the spread operator from module declaration. See: https://github.com/angular/angular/issues/29835 Related issue: #112

wuboy0307 commented 4 years ago

This could be fix on latest angular 9 rc https://github.com/angular/angular/issues/33614

kubk commented 4 years ago

@wuboy0307 Yes, I see this commit: https://github.com/angular/angular/commit/d749dd3ea1865c2ff7252415227e0210bea96983 I've updated Angular to RC 11 and still receive the same error.

henryruhs commented 4 years ago

@kubk It works for me with RC11... what is inside your tsconfig?

Try this:

{
    "module": "esnext",
    "target": "es2015"
}
michaill commented 4 years ago

will there be a release including this change?

adamkleingit commented 4 years ago

I just published 3.1.1, but haven't had the time to test it yet against Angular 9. @michaill @kubk - can any of you verify? Thanks

kubk commented 4 years ago

Hi @adamkleingit I have tested it on a fresh Angular 9 app and I see no compile issues. Thank you.

michaill commented 4 years ago

I have tried to build new angular-tree-component using this package and still has the same issue, but it is not mobx-angular's fault. thanks a lot I will keep trying :)

EDIT: I had wrong dependencies. it is fixing angular-tree-component, too.