mobxjs / mobx-angular

The MobX connector for Angular.
MIT License
483 stars 59 forks source link

fail to run with angular 9 #116

Closed ronentidhar closed 4 years ago

ronentidhar commented 4 years ago

ng serve 0% compiling Compiling @angular/core : module as esm5

Compiling @angular/common : module as esm5

Compiling @angular/platform-browser : module as esm5

Compiling @angular/platform-browser-dynamic : module as esm5

Compiling angular-tree-component : module as esm5

chunk {main} main.js, main.js.map (main) 1.96 kB [initial] [rendered] chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 660 bytes [initial] [rendered] chunk {polyfills-es5} polyfills-es5.js, polyfills-es5.js.map (polyfills-es5) 433 kB [initial] [rendered] chunk {runtime} runtime.js, runtime.js.map (runtime) 6.15 kB [entry] [rendered] chunk {styles} styles.js, styles.js.map (styles) 21.9 kB [initial] [rendered] chunk {vendor} vendor.js, vendor.js.map (vendor) 340 kB [initial] [rendered] Date: 2020-02-12T20:54:39.077Z - Hash: 24936f4fa038e3738fa4 - Time: 12665ms

**ERROR in Failed to compile entry-point angular-tree-component (module as esm5) due to compilation errors: node_modules/mobx-angular/dist/mobx-angular.d.ts:8:22 - error NG6002: Appears in the NgModule.imports of TreeModule, but could not be resolved to an NgModule class

8 export declare class MobxAngularModule {**

ronentidhar commented 4 years ago

Same with es2015

ng serve 0% compiling Compiling @angular/core : es2015 as esm2015

Compiling @angular/common : es2015 as esm2015

Compiling @angular/platform-browser : es2015 as esm2015

Compiling @angular/platform-browser-dynamic : es2015 as esm2015

Compiling angular-tree-component : module as esm5

chunk {main} main.js, main.js.map (main) 1.96 kB [initial] [rendered] chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 660 bytes [initial] [rendered] chunk {runtime} runtime.js, runtime.js.map (runtime) 6.15 kB [entry] [rendered] chunk {styles} styles.js, styles.js.map (styles) 21.9 kB [initial] [rendered] chunk {vendor} vendor.js, vendor.js.map (vendor) 340 kB [initial] [rendered] Date: 2020-02-12T20:59:29.537Z - Hash: bdb20b434969968c1c12 - Time: 9574ms

ERROR in Failed to compile entry-point angular-tree-component (module as esm5) due to compilation errors: node_modules/mobx-angular/dist/mobx-angular.d.ts:8:22 - error NG6002: Appears in the NgModule.imports of TreeModule, but could not be resolved to an NgModule class

8 export declare class MobxAngularModule {

kubk commented 4 years ago

Which version of mobx-angular are you using? Angular 9 support was added recently: https://github.com/mobxjs/mobx-angular/issues/112 Could you create a repo with reproduction?

Cpassimal commented 4 years ago

Same here

ERROR in Failed to compile entry-point angular-tree-component (module as esm5) due to compilation errors: node_modules/mobx-angular/dist/mobx-angular.d.ts:8:22 - error NG6002: Appears in the NgModule.imports of TreeModule, but could not be resolved to an NgModule class

8 export declare class MobxAngularModule {

I checked on the node_modules/mobx-angular, the version 3.1.1 is indeed here.

kubk commented 4 years ago

@Cpassimal Please read my comment above. A repro (on stackblitz or codesandbox) would be helpful. Here is an example with Angular 9 and Mobx working together: https://stackblitz.com/edit/angular-gd1ybt?file=package.json

Cpassimal commented 4 years ago

I was having this issue using angular-tree-component in the version 8.5.4, 8.5.5 solved the problem.

Mattnmoore commented 4 years ago

I'm also running into this issue with Angular 9 with Ivy enabled. 3.0.3 works with Ivy disabled.

I was having this issue using angular-tree-component in the version 8.5.4, 8.5.5 solved the problem.

It looks like they manually pulled in mobx-angular and made changes to it to get it to work with their library.

adamkleingit commented 4 years ago

This was fixed in angular-tree-compoment version 8.5.6