mobxjs / mobx-angular

The MobX connector for Angular.

MIT License

483 stars 59 forks source link

New Mobx version #125

Closed nicolidin closed 2 years ago

nicolidin commented 3 years ago

As Mobx is now in 6.0.1, this repository should add in the ReadMe and in the examples (should update mobx version) makeObservable(this) or makeAutoObservable(this) (if no decorators) in the constructor. If decorators is used "useDefineForClassFields": true should be added to in tsconfig.json too.

(if you validate I can create the pr)

adamkleingit commented 3 years ago

True, @nicolidin care to make a PR? That would be very helpful for the repo and the community. Thanks!

EVASIVE commented 3 years ago

@adamkleingit I am also faced with inconsistence of mobx-angular example and mobx documentation, so I created PR with these changes

138

SimonMcKinsey commented 2 years ago

Thanks @EVASIVE, This has been merged (#138). Closing.