Support Angular 10 and above

mobxjs / mobx-angular

The MobX connector for Angular.

MIT License

483 stars 59 forks source link

Support Angular 10 and above #127

Closed th0r closed 3 years ago

th0r commented 3 years ago

Current version of this package supports only v9: https://github.com/mobxjs/mobx-angular/blob/6bf39d7faa8e2050c23aacdfd9fefbd56e04c1ff/projects/mobx-angular/package.json#L6-L7

It would be great to also support Angular 10 and above.

popec commented 3 years ago

We're on Angular 11 and getting JS error with "aot": true and "optimization": true, "buildOptimizer": true TypeError: t.make_ is not a function It works when:

we set aot: false or
we set aot: true, optimization: false or
we set aot: true, optimization: true, buildOptimizer: false (which is our current solution)

Any chances for Angular 11 with buildOptimizer enabled ?

reidkornman commented 3 years ago

Sticking to the root of this ask... when will Angular 11 support be consider/added?

adamkleingit commented 3 years ago

Anyone wants to try and solve this and open a PR? @popec @reidkornman @th0r It would be much appreciated. Thanks!

popec commented 3 years ago

It's not helping, same thing happens after building app with buildOptimizer: true in angular.json as before. It's probably mobx itself not being ok with uglify maybe?