Now able to pass all options to both reaction and autorun directives.

mobxjs / mobx-angular

The MobX connector for Angular.

MIT License

483 stars 59 forks source link

Now able to pass all options to both reaction and autorun directives. #129

Closed OmerGronich closed 3 years ago

OmerGronich commented 3 years ago

This required me to change how the reaction directive works. In order to be able to pass all the available options, you now pass the data function in an object similar to how you do with the autorun directive options.
explained usage in the README.md, and updated the reaction usage example as well.

adamkleingit commented 3 years ago

Hi @OmerGronich - thanks for following through with this. That's not good because it's a breaking change to the API. Is it possible to add the options as a second input?

OmerGronich commented 3 years ago

Hi @OmerGronich - thanks for following through with this. That's not good because it's a breaking change to the API. Is it possible to add the options as a second input?

Yes I thought this would be a problem. I'll try to figure it out and submit another pull request soon.

OmerGronich commented 3 years ago

Hi @OmerGronich - thanks for following through with this. That's not good because it's a breaking change to the API. Is it possible to add the options as a second input?

Fixed it so in the mobxReaction directive you can now pass a second parameter after the function, called options.

The mobxAutorun directive still accepts only one input

Let me know if this is ok