search

mobxjs / mobx-react

React bindings for MobX
https://mobx.js.org/react-integration.html
MIT License
4.85k stars 349 forks source link

Issue #824: Convert tests from JavaScript to TypeScript #826

Closed ynejati closed 4 years ago

ynejati commented 4 years ago

Converting tests from JS to TS, picking up where the src JS to TS conversion left off.

ynejati commented 4 years ago

Requested changes made, and all CI checks have passed. I think we are ready.

Bnaya commented 4 years ago

@ynejati you changes has bean approved, after you fix the conflicts you should be able to hit the merge

ynejati commented 4 years ago

Cool! Thanks @Bnaya.

ynejati commented 4 years ago

@Bnaya, I ran prettier over your files after converting to TS. I hope you don't mind.

ynejati commented 4 years ago

Hahaha.. darn it @FredyC . No problem. I'll resolve conflicts later today.

danielkcz commented 4 years ago

Thanks for the great work @ynejati