search

mobxjs / mobx-react

React bindings for MobX
https://mobx.js.org/react-integration.html
MIT License
4.85k stars 349 forks source link

IE11 Issue around Symbols #834

Closed paulmowat closed 4 years ago

paulmowat commented 4 years ago

Hi.

Think I've found a issue in IE11 while updating my projects dependencies.

Looks like

mobx4 + mobx-react6.1.5 => success mobx4 + mobx-react6.1.7 => fail

From what I can tell it looks like a issue to do with symbols.

On debugging it seems to be coming from src/utils/utils.ts in the following code

function createSymbol(name) { if (typeof Symbol === "function") { return Symbol(name); }

const symbol = __$mobx-react ${name} (${symbolId}); symbolId++; return symbol; }

Getting a invalid character error at "const symbol = __$mobx-react ${name} (${symbolId});"

image

Thanks

Paul

danielkcz commented 4 years ago

Thanks for the report. We have changed the way how the module is built and haven't considered ES5 for bundling. I will fix that soon.

danielkcz commented 4 years ago

Closing this in favor of more comprehensive #835, subscribe there to watch for resolution, please.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.